Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move base req. to root #4219

Merged
merged 5 commits into from
Oct 18, 2020
Merged

move base req. to root #4219

merged 5 commits into from
Oct 18, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 18, 2020

What does this PR do?

as @williamFalcon requested... :]

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactor label Oct 18, 2020
@mergify mergify bot requested a review from a team October 18, 2020 16:13
@Borda Borda marked this pull request as draft October 18, 2020 16:53
@Borda Borda marked this pull request as ready for review October 18, 2020 17:02
@codecov
Copy link

codecov bot commented Oct 18, 2020

Codecov Report

Merging #4219 into master will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4219   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         103     103           
  Lines        7847    7848    +1     
======================================
+ Hits         7280    7281    +1     
  Misses        567     567           

Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a good change imo :)

@Borda Borda merged commit d3567c3 into master Oct 18, 2020
@ydcjeff ydcjeff deleted the refactor/move-req branch October 19, 2020 03:11
@Borda Borda added this to the 1.0.x milestone Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants