Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG-FIX] WandbLogger _sanitize_callable #4422

Merged
merged 5 commits into from
Nov 2, 2020

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Oct 29, 2020

What does this PR do?

The PR fixes an issue introduced with WandbLogger.

Fixes #4380

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Oct 29, 2020

Hello @tchaton! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-11-02 08:00:17 UTC

@tchaton tchaton changed the title fix [BUG-FIX] WandbLogger _sanitize_callable Oct 29, 2020
@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #4422 into master will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4422   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         113     113           
  Lines        8192    8192           
======================================
- Hits         7624    7621    -3     
- Misses        568     571    +3     

@ydcjeff ydcjeff added bug Something isn't working logger Related to the Loggers labels Oct 29, 2020
@ydcjeff ydcjeff added this to the 1.0.x milestone Oct 29, 2020
pytorch_lightning/loggers/base.py Outdated Show resolved Hide resolved
@SkafteNicki SkafteNicki merged commit c2e72c3 into master Nov 2, 2020
@tchaton tchaton deleted the bugfix/4380_sanitize_callable_params branch November 2, 2020 09:10
Borda pushed a commit that referenced this pull request Nov 4, 2020
* fix

* resolve CodeFormatter

* Update pytorch_lightning/loggers/base.py

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
(cherry picked from commit c2e72c3)
rohitgr7 pushed a commit that referenced this pull request Nov 21, 2020
* fix

* resolve CodeFormatter

* Update pytorch_lightning/loggers/base.py

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logger Related to the Loggers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WandbLogger _sanitize_callable_params throws AttributeError if param does not have __name__
6 participants