Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Set split_idx from logger_connector to trainer. #4697

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 16, 2020

What does this PR do?

Fixes #4682

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton added logger Related to the Loggers bug Something isn't working labels Nov 16, 2020
@tchaton tchaton self-assigned this Nov 16, 2020
@tchaton tchaton added this to the 1.0.x milestone Nov 16, 2020
@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #4697 (6fbe126) into master (5109766) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4697   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         117     117           
  Lines        8932    8933    +1     
======================================
- Hits         8301    8299    -2     
- Misses        631     634    +3     

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls update the changelog and still some checks are missing in the PR body :]

@tchaton tchaton merged commit 96769a7 into master Nov 16, 2020
@tchaton tchaton deleted the bugfix/4682_tbptt_on_validation_step branch November 16, 2020 16:20
tchaton added a commit that referenced this pull request Nov 17, 2020
rohitgr7 pushed a commit that referenced this pull request Nov 21, 2020
@jeremyjordan
Copy link
Contributor

sorry for the late reply, but could we add a test that uses tbptt with a validation step to prevent future regressions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logger Related to the Loggers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tbptt doesn't work with validation step enabled
6 participants