Fixed a crash bug in MLFlow logger #4716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d string or bytes-like object" when the execution flow gets to this warning. Fixed that.
pgagarinov
requested review from
ananyahjha93,
awaelchli,
Borda,
justusschock,
nateraw,
SeanNaren,
tchaton,
teddykoker and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4716 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 118 118
Lines 9032 9031 -1
======================================
- Hits 8404 8403 -1
Misses 628 628 |
Borda
requested changes
Nov 17, 2020
rohitgr7
approved these changes
Nov 21, 2020
rohitgr7
removed
the
waiting on author
awaelchli
approved these changes
Nov 21, 2020
SkafteNicki
approved these changes
Nov 22, 2020
tchaton
approved these changes
Nov 23, 2020
Borda
approved these changes
Nov 23, 2020
Borda
pushed a commit
that referenced
this pull request
Nov 24, 2020
* warnings.warn doesn't accept tuples, which causes "TypeError: expected string or bytes-like object" when the execution flow gets to this warning. Fixed that. * Try adding a mock test * Try adding a mock test Co-authored-by: rohitgr7 <rohitgr1998@gmail.com> Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit 70361eb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On line 159 of loggers/mlflow.py warnings.warn there was a typo - warn doesn't accept tuples which causes "TypeError: expected string or bytes-like object" when the execution flow gets to this warning. Fixed that.