5/n: Extract reference model call to plugins/accelerators #4773
+181
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 19, 2020 10:43
…tom wrapper logic to live within the plugin/accelerators
SeanNaren
requested review from
ananyahjha93,
awaelchli,
Borda,
justusschock,
nateraw,
tchaton,
teddykoker and
williamFalcon
as code owners
|
Hello @SeanNaren! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-11-23 16:38:09 UTC |
added 2 commits
November 19, 2020 10:52
justusschock
approved these changes
Nov 19, 2020
|
@SeanNaren I like it. This seems like a trivial function now, but could you maybe add a test for it to ensure that it still works, if we may come to more complicated cases? |
Absolutely, will do. Also ddp plugin tests are failing, need to ensure this logic is overridden correctly in the tests. |
Codecov Report
@@ Coverage Diff @@
## master #4773 +/- ##
======================================
Coverage 93% 93%
======================================
Files 118 118
Lines 9018 9020 +2
======================================
+ Hits 8389 8393 +4
+ Misses 629 627 -2 |
SeanNaren
commented
Nov 20, 2020
tchaton
requested changes
Nov 20, 2020
Borda
reviewed
Nov 20, 2020
tchaton
approved these changes
Nov 23, 2020
SeanNaren
changed the title
Borda
reviewed
Nov 23, 2020
Borda
approved these changes
Nov 23, 2020
williamFalcon
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #4753. Final API change to allow custom DDP wrapper logic when extracting reference model.
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃