Add batch_arg_name to all calls to _adjust_batch_size
#4812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `batch_arg_name` to all calls to `_adjust_batch_size`
M-Salti
requested review from
ananyahjha93,
awaelchli,
Borda,
justusschock,
nateraw,
SeanNaren,
tchaton,
teddykoker and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4812 +/- ##
======================================
Coverage 93% 93%
======================================
Files 117 117
Lines 9010 9010
======================================
Hits 8383 8383
Misses 627 627 |
rohitgr7
approved these changes
Nov 22, 2020
awaelchli
approved these changes
Nov 23, 2020
s-rog
approved these changes
Nov 23, 2020
Borda
pushed a commit
that referenced
this pull request
Nov 23, 2020
Add `batch_arg_name` to all calls to `_adjust_batch_size` (cherry picked from commit cd90dd4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
scale_batch_sizewhen using abatch_arg_nameother than the default'batch_size'; not all the calls to_adjust_batch_sizeare passingbatch_arg_namecausing an exception when usingbatch_arg_name='bs'for example.Here are two Colabs showing the bug and the fix:
1- (Bug) Install PL from the master branch: https://colab.research.google.com/drive/1VgLVfBl2xB0TJz4Js_xDSgz-Ae_fi_Jt
2- (Fix) Install PL from my master branch: https://colab.research.google.com/drive/1yierw80jgJb0qukBiCw54iNSelK8qJYB
The only difference is in the first cell (installation source).