Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start version suffixes at 1 #5008

Merged
merged 31 commits into from
Jan 26, 2021
Merged

Start version suffixes at 1 #5008

merged 31 commits into from
Jan 26, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Dec 7, 2020

What does this PR do?

It is assumed that file.ckpt would correspond to -v0. Chose not to rename it to file-v0.ckpt after the discussion at #5030 (comment)

Fixes #5000

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

@pep8speaks
Copy link

pep8speaks commented Dec 7, 2020

Hello @carmocca! Thanks for updating this PR.

Line 547:13: W503 line break before binary operator
Line 548:13: W503 line break before binary operator
Line 549:13: W503 line break before binary operator

Comment last updated at 2021-01-26 20:07:19 UTC

@Borda
Copy link
Member

Borda commented Dec 8, 2020

@carmocca any update here?

@Borda Borda added design Includes a design discussion checkpointing Related to checkpointing refactor labels Dec 8, 2020
@Borda Borda added this to the 1.1 milestone Dec 8, 2020
@carmocca
Copy link
Contributor Author

carmocca commented Dec 8, 2020

@carmocca any update here?

I implemented a test by calling .fit() twice. But that does not work properly due to #5007, hence why this PR is blocked by that issue.

Otherwise (assuming no bugs when #5007 is solved) it should be ready to review.

@carmocca carmocca changed the title Rename first checkpoint to use the v0 suffix Start version suffixes at 1 Dec 10, 2020
@carmocca carmocca marked this pull request as ready for review December 10, 2020 01:23
@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #5008 (b60982a) into release/1.2-dev (dee5553) will decrease coverage by 0%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           release/1.2-dev   #5008   +/-   ##
===============================================
- Coverage               93%     93%   -0%     
===============================================
  Files                  154     154           
  Lines                11041   11040    -1     
===============================================
- Hits                 10218   10216    -2     
- Misses                 823     824    +1     

@mergify mergify bot requested a review from a team December 12, 2020 14:56
pytorch_lightning/callbacks/model_checkpoint.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/model_checkpoint.py Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 enabled auto-merge (squash) January 21, 2021 14:32
@mergify mergify bot removed the has conflicts label Jan 22, 2021
@rohitgr7 rohitgr7 merged commit 9d165f6 into Lightning-AI:release/1.2-dev Jan 26, 2021
@carmocca carmocca deleted the 5000 branch January 26, 2021 22:48
@carmocca carmocca self-assigned this Nov 1, 2023
@mergify mergify bot added the ready PRs ready to be merged label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checkpointing Related to checkpointing design Includes a design discussion feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add version suffix to saved model checkpoint with a version
7 participants