Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support number for logging with sync_dist=True #5080

Merged
merged 17 commits into from
Dec 16, 2020
Merged

support number for logging with sync_dist=True #5080

merged 17 commits into from
Dec 16, 2020

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Dec 11, 2020 •
edited
Loading

What does this PR do?

This PR clone value only if it is a tensor.

Fixes #5003

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Dec 11, 2020 •
edited
Loading

Hello @tchaton! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-12-14 07:38:41 UTC

@tchaton tchaton added the logger Related to the Loggers label Dec 11, 2020
@tchaton tchaton self-assigned this Dec 11, 2020
@tchaton tchaton added this to the 1.2.x milestone Dec 11, 2020
@tchaton tchaton marked this pull request as ready for review December 11, 2020 13:05
@codecov
Copy link

codecov bot commented Dec 11, 2020 •
edited
Loading

Codecov Report

Merging #5080 (453d3e9) into master (b4d926b) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #5080   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         134     134           
  Lines        9905    9907    +2     
======================================
+ Hits         9204    9206    +2     
  Misses        701     701

@tchaton tchaton modified the milestones: 1.2.x, 1.1.x Dec 11, 2020
Borda
Borda approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

justusschock
justusschock approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tchaton @carmocca
Update pytorch_lightning/core/step_result.py
719457d 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@carmocca carmocca mentioned this pull request Dec 12, 2020
Closed
11 tasks
awaelchli
awaelchli approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is very strange that all other tests that use sync_dist=True only run on a single gpu. these tests should probably be revised

@tchaton
Copy link
Contributor Author

tchaton commented Dec 16, 2020

it is very strange that all other tests that use sync_dist=True only run on a single gpu. these tests should probably be revised

Yes, entirely agree. I was confused too when I looked at them. We definitely need better tests around sync.

Best,

@tchaton tchaton added the ready PRs ready to be merged label Dec 16, 2020
@williamFalcon williamFalcon merged commit 140c37a into master Dec 16, 2020
@tchaton tchaton deleted the bugfix/5003_float_has_no_clone branch December 16, 2020 21:08
awaelchli pushed a commit that referenced this pull request Dec 18, 2020
@tchaton @carmocca @awaelchli
support number for logging with sync_dist=True (#5080)
b3fc662 
* support number

* add two tests

* wip

* add ddp in special test

* remove a test

* move device to bottom

* simplify test

* update test

* Update pytorch_lightning/core/step_result.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* resolve sync_ddp

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Borda pushed a commit that referenced this pull request Dec 23, 2020
@tchaton @carmocca @Borda
support number for logging with sync_dist=True (#5080)
92e714e 
* support number

* add two tests

* wip

* add ddp in special test

* remove a test

* move device to bottom

* simplify test

* update test

* Update pytorch_lightning/core/step_result.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* resolve sync_ddp

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Borda pushed a commit that referenced this pull request Dec 29, 2020
@tchaton @carmocca @Borda
support number for logging with sync_dist=True (#5080)
25640bc 
* support number

* add two tests

* wip

* add ddp in special test

* remove a test

* move device to bottom

* simplify test

* update test

* Update pytorch_lightning/core/step_result.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* resolve sync_ddp

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Borda pushed a commit that referenced this pull request Jan 4, 2021
@tchaton @carmocca @Borda
support number for logging with sync_dist=True (#5080)
6df19ef 
* support number

* add two tests

* wip

* add ddp in special test

* remove a test

* move device to bottom

* simplify test

* update test

* Update pytorch_lightning/core/step_result.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* resolve sync_ddp

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Borda pushed a commit that referenced this pull request Jan 4, 2021
@tchaton @carmocca @Borda
support number for logging with sync_dist=True (#5080)
8484f2b 
* support number

* add two tests

* wip

* add ddp in special test

* remove a test

* move device to bottom

* simplify test

* update test

* Update pytorch_lightning/core/step_result.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* resolve sync_ddp

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Borda pushed a commit that referenced this pull request Jan 5, 2021
@tchaton @carmocca @Borda
support number for logging with sync_dist=True (#5080)
58a2993 
* support number

* add two tests

* wip

* add ddp in special test

* remove a test

* move device to bottom

* simplify test

* update test

* Update pytorch_lightning/core/step_result.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* resolve sync_ddp

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@carmocca carmocca carmocca approved these changes

@justusschock justusschock justusschock approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@tchaton tchaton

Labels
logger Related to the Loggers ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.1.x
9 participants
@tchaton @pep8speaks @awaelchli @Borda @carmocca @justusschock @SkafteNicki @rohitgr7 @williamFalcon