Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] remove nan loss in manual optimization #5121

Merged
merged 7 commits into from
Dec 16, 2020
Merged

[bugfix] remove nan loss in manual optimization #5121

merged 7 commits into from
Dec 16, 2020

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Dec 14, 2020 •
edited
Loading

What does this PR do?

This PR fixes progress bar displaying NaN loss in manual_optimization.

Fixes #5123

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton added logger Related to the Loggers priority: 1 Medium priority task labels Dec 14, 2020
@tchaton tchaton added this to the 1.1.x milestone Dec 14, 2020
@tchaton tchaton self-assigned this Dec 14, 2020
@Borda Borda added the bug Something isn't working label Dec 14, 2020
Borda
Borda approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Dec 14, 2020 •
edited
Loading

Codecov Report

Merging #5121 (5bb7406) into master (b4d926b) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #5121   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         134     134           
  Lines        9905    9911    +6     
======================================
+ Hits         9204    9210    +6     
  Misses        701     701

@tchaton tchaton added the ready PRs ready to be merged label Dec 16, 2020
@williamFalcon williamFalcon merged commit 8d1ca4c into master Dec 16, 2020
@tchaton tchaton deleted the bugfix/manual_optimizaiton_loss_nan branch December 16, 2020 21:15
awaelchli pushed a commit that referenced this pull request Dec 18, 2020
@tchaton @carmocca
@rohitgr7 @awaelchli
[bugfix] remove nan loss in manual optimization (#5121)
29c6bf5 
* remove nan loss whe missing

* Update pytorch_lightning/core/lightning.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Borda pushed a commit that referenced this pull request Dec 23, 2020
@tchaton @carmocca
@rohitgr7 @Borda
[bugfix] remove nan loss in manual optimization (#5121)
824fad8 
* remove nan loss whe missing

* Update pytorch_lightning/core/lightning.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Borda pushed a commit that referenced this pull request Dec 29, 2020
@tchaton @carmocca
@rohitgr7 @Borda
[bugfix] remove nan loss in manual optimization (#5121)
fc1861d 
* remove nan loss whe missing

* Update pytorch_lightning/core/lightning.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Borda pushed a commit that referenced this pull request Jan 4, 2021
@tchaton @carmocca
@rohitgr7 @Borda
[bugfix] remove nan loss in manual optimization (#5121)
d3eff1f 
* remove nan loss whe missing

* Update pytorch_lightning/core/lightning.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Borda pushed a commit that referenced this pull request Jan 4, 2021
@tchaton @carmocca
@rohitgr7 @Borda
[bugfix] remove nan loss in manual optimization (#5121)
0e81284 
* remove nan loss whe missing

* Update pytorch_lightning/core/lightning.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Borda pushed a commit that referenced this pull request Jan 5, 2021
@tchaton @carmocca
@rohitgr7 @Borda
[bugfix] remove nan loss in manual optimization (#5121)
9669c80 
* remove nan loss whe missing

* Update pytorch_lightning/core/lightning.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 left review comments

@Borda Borda Borda approved these changes

@carmocca carmocca carmocca approved these changes

@justusschock justusschock justusschock approved these changes

@s-rog s-rog s-rog approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@tchaton tchaton

Labels
bug Something isn't working logger Related to the Loggers priority: 1 Medium priority task ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.1.x
Development

Successfully merging this pull request may close these issues.

In manual optimization, loss=NaN is displayed in progress_bar
7 participants
@tchaton @Borda @carmocca @justusschock @rohitgr7 @s-rog @williamFalcon