add promxial policy optimization template to pl_examples #5394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidhantls
requested review from
awaelchli,
Borda,
justusschock,
SeanNaren,
tchaton and
williamFalcon
as code owners
|
Hello @sid-sundrani! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-01-09 17:29:18 UTC |
sidhantls
requested review from
ananyahjha93,
nateraw and
teddykoker
as code owners
|
I added my code to the wrong branch (master) and I'm merging with 1.0.x.. There seem to be 448 commits in this PR now. Not sure what to do, should i hard reset my branch to PyTorchLightning:release/1.0.x and add the file to that again? |
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5394 +/- ##
===============================================
Coverage 93% 93%
===============================================
Files 151 151
Lines 10619 10619
===============================================
Hits 9832 9832
Misses 787 787 |
|
@sid-sundrani well in fact the correct for you is |
tchaton
reviewed
Jan 7, 2021
ananyahjha93
approved these changes
Jan 7, 2021
marload
suggested changes
Jan 8, 2021
tchaton
approved these changes
Jan 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds example of implementation of proximal policy optimization in PyTorch Lightning.
I had implemented PPO in Lightning in my repo and there are some results there as well. If it's good to have an example for PPO in pl_examples, I'm happy to help add it
Fixes #5393
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃