-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accelerator Refactor/RPC + Sharded #5732
Conversation
Hello @justusschock! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-02-01 11:19:59 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! I think we will have to be careful with duplicated code for Plugin as Shared.
just add chlog :] |
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5732 +/- ##
================================================
- Coverage 89% 89% -0%
================================================
Files 173 173
Lines 12495 12339 -156
================================================
- Hits 11171 11007 -164
- Misses 1324 1332 +8 |
This should be the last PR adding new classes for the accelerator refactor (#5616 ).
It should be merged after #5719 .
It adds support for sharded training and RPC/Model parallelism.