Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify variables: step, epoch, max_epochs, min_epochs #589

Merged
merged 1 commit into from
Dec 7, 2019
Merged

Simplify variables: step, epoch, max_epochs, min_epochs #589

merged 1 commit into from
Dec 7, 2019

Conversation

elliotwaite
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #584.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is hard to see from the changes it it was changed everywhere, but otherwise it LGTM :]

@williamFalcon williamFalcon merged commit 1051c18 into Lightning-AI:master Dec 7, 2019
@awaelchli
Copy link
Contributor

It was not changed here for example.

@elliotwaite
Copy link
Contributor Author

It was not changed here for example.

This change only addressed changing all max_num_epochs to max_epochs. Perhaps @Borda can help us out here, he worked on a previous change (#567) that addressed the switch from max_nb_epochs to max_num_epochs while preserving backward compatibility.

@Borda, any suggestions?

@Borda
Copy link
Member

Borda commented Dec 8, 2019

it should be change there too and propagate the change across system...
for back compatibility, add a property with the max_nb_epochs and dedicated warning

@poperty
def max_nb_epochs(self):
    """
    .. warning:: Deprecated... will be removed...
    """
    warn("Depredated... will be removed...", DeprecationWarning)
    return self.max_epochs

@elliotwaite @awaelchli willing to prepare follow-up PR?

@elliotwaite
Copy link
Contributor Author

Thanks, @Borda. Created a PR: #613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants