Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TensorboardLogger #607

Merged
merged 3 commits into from
Dec 8, 2019
Merged

Conversation

neggert
Copy link
Contributor

@neggert neggert commented Dec 8, 2019

Implement a simple Tensorboard logger. No more external dependencies for basic logging!

Only question on this one is how to deal with the fact that SummaryWriter.add_hparams wasn't added until torch 1.3.0. Right now, I just throw a warning and skip writting hparams to Tensorboard. The only other thing I can think of would be to write the hparams to a text file in the same directory as the TB logs.

Closes #588
Closes #265

@williamFalcon williamFalcon merged commit 5329c72 into Lightning-AI:master Dec 8, 2019
@williamFalcon
Copy link
Contributor

@neggert amazing. let's make this the default logger and remove the test-tube dep?

@Borda
Copy link
Member

Borda commented Dec 8, 2019

@neggert @williamFalcon There are many bugs in this PR, pls fix them in the follow-up #609

@Borda Borda mentioned this pull request Dec 8, 2019
@awaelchli
Copy link
Contributor

btw, the official spelling is TensorBoard (not Tensorboard). I would consider renaming to TensorBoardLogger.

@williamFalcon
Copy link
Contributor

agreed. mind submitting a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logger: add TensorBoard without tensorFlow Add tensorboard logger
4 participants