Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] DeepSpeed with no schedulers #8580

Merged
merged 7 commits into from
Jul 27, 2021
Merged

[bugfix] DeepSpeed with no schedulers #8580

merged 7 commits into from
Jul 27, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Jul 27, 2021

What does this PR do?

On master:
Screenshot 2021-07-27 at 15 58 09

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Jul 27, 2021

Hello @tchaton! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-27 14:29:09 UTC

@tchaton tchaton self-assigned this Jul 27, 2021
@tchaton tchaton added this to the v1.4 milestone Jul 27, 2021
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #8580 (cfa72b7) into master (c5167e9) will decrease coverage by 4%.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master   #8580    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         218     218            
  Lines       14403   14412     +9     
=======================================
- Hits        13299   12712   -587     
- Misses       1104    1700   +596     

Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great fix, thanks @tchaton!

@SeanNaren SeanNaren added ready PRs ready to be merged bug Something isn't working labels Jul 27, 2021
@SeanNaren SeanNaren modified the milestones: v1.4, v1.4.x Jul 27, 2021
@SeanNaren SeanNaren added the 3rd party Related to a 3rd-party label Jul 27, 2021
@kaushikb11 kaushikb11 enabled auto-merge (squash) July 27, 2021 14:07
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

the chlog will have to move up after the recent 1.4 release :)

tests/plugins/test_deepspeed_plugin.py Outdated Show resolved Hide resolved
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
@kaushikb11
Copy link
Contributor

the chlog will have to move up after the recent 1.4 release :)

I haven't published the release yet. Will add this as well.

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@kaushikb11 kaushikb11 merged commit c7f8c8c into master Jul 27, 2021
@kaushikb11 kaushikb11 deleted the deepspeed_fix branch July 27, 2021 15:28
awaelchli pushed a commit that referenced this pull request Jul 31, 2021
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
awaelchli pushed a commit that referenced this pull request Jul 31, 2021
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@awaelchli awaelchli modified the milestones: v1.4.x, v1.4 Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Related to a 3rd-party bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants