Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add_argparse_args raising TypeError with Python 3.6 #9554

Merged
merged 5 commits into from
Sep 17, 2021

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Sep 16, 2021

What does this PR do?

Fixes #9535.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@akihironitta akihironitta added the bug Something isn't working label Sep 16, 2021
@akihironitta akihironitta changed the title [wip] Fix add_argparse_args raising TypeError with Python 3.6 Fix add_argparse_args raising TypeError with Python 3.6 Sep 16, 2021
@akihironitta akihironitta changed the title Fix add_argparse_args raising TypeError with Python 3.6 [wip] Fix add_argparse_args raising TypeError with Python 3.6 Sep 16, 2021
@akihironitta akihironitta marked this pull request as ready for review September 16, 2021 09:18
@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #9554 (ac2196a) into master (86c0335) will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #9554   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         180     180           
  Lines       15090   15090           
======================================
  Hits        14019   14019           
  Misses       1071    1071           

@akihironitta akihironitta changed the title [wip] Fix add_argparse_args raising TypeError with Python 3.6 Fix add_argparse_args raising TypeError with Python 3.6 Sep 16, 2021
@akihironitta
Copy link
Contributor Author

The failing tests are irrelevant to the changes made here. Also, DeepSource is complaining that __init__ doesn't contain any code at:
https://github.com/PyTorchLightning/pytorch-lightning/blob/ac2196afd541ddd9faf234192083077cd50f816c/tests/utilities/test_argparse.py#L146

but a test class above also doesn't contain any code in __init__
https://github.com/PyTorchLightning/pytorch-lightning/blob/ac2196afd541ddd9faf234192083077cd50f816c/tests/utilities/test_argparse.py#L136

so I believe this PR is ready for your review now.

@carmocca carmocca added this to the v1.4.x milestone Sep 16, 2021
@mergify mergify bot added the ready PRs ready to be merged label Sep 17, 2021
@Borda Borda merged commit 11c93d9 into master Sep 17, 2021
@Borda Borda deleted the bugfix/argparse-py36 branch September 17, 2021 09:24
tchaton pushed a commit that referenced this pull request Sep 21, 2021
* Add test
* Accept TypeError for arg_type.__args__ being None

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
tchaton pushed a commit that referenced this pull request Sep 21, 2021
* Add test
* Accept TypeError for arg_type.__args__ being None

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
carmocca pushed a commit that referenced this pull request Sep 21, 2021
* Add test
* Accept TypeError for arg_type.__args__ being None

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
lexierule pushed a commit that referenced this pull request Sep 22, 2021
* Add test
* Accept TypeError for arg_type.__args__ being None

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
SeanNaren pushed a commit that referenced this pull request Sep 22, 2021
* Add test
* Accept TypeError for arg_type.__args__ being None

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add_argparse_args raises TypeError with Python 3.6 when class has arg typed Generic
4 participants