Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Intents.all returning the wrong value #2257

Merged
merged 9 commits into from
Dec 2, 2023
Merged

fix: Intents.all returning the wrong value #2257

merged 9 commits into from
Dec 2, 2023

Conversation

Aityz
Copy link
Contributor

@Aityz Aityz commented Nov 8, 2023

Summary

This pull request fixes Issue 2195, with reusable code that gets every flag and removes the unused flags, instead of getting the highest flag.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Lulalaby Lulalaby changed the title Fixed Issue #2195 fix: Fixed discord.Intents.all() returning the wrong value. Nov 8, 2023
Lulalaby
Lulalaby previously approved these changes Nov 8, 2023
@Lulalaby Lulalaby enabled auto-merge (squash) November 8, 2023 12:14
@Lulalaby Lulalaby added the bug Something isn't working label Nov 8, 2023
discord/flags.py Outdated Show resolved Hide resolved
Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@Dorukyum Dorukyum changed the title fix: Fixed discord.Intents.all() returning the wrong value. fix: Intents.all returning the wrong value Dec 2, 2023
Dorukyum
Dorukyum previously approved these changes Dec 2, 2023
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The merge commit dismissed my review

@Lulalaby Lulalaby merged commit 6bfae7f into Pycord-Development:master Dec 2, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intents wrong value
3 participants