Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion Feature doesn't migrate everything from ZNPCs plugin #118

Closed
MineFact opened this issue Jan 12, 2024 · 0 comments · Fixed by #119
Closed

Conversion Feature doesn't migrate everything from ZNPCs plugin #118

MineFact opened this issue Jan 12, 2024 · 0 comments · Fixed by #119

Comments

@MineFact
Copy link
Contributor

Hey,

when using the Conversion Feature to migrate data from the ZNPCs plugin, some of the data is not getting migrated.

In my case 2 things are not migrated:

  1. The npcFunctions value for each NPC in data.json
  2. All conversations from conversations.json

Here is an example NPC from the file ServersNPC/data.json including the conversation and npcFunctions values:

{
    "id": 1,
    "hologramHeight": 0.0,
    "skin": "ewogICJ0aW1lc3RhbXAiIDogMTY4NDkzOTQxNTI0OSwKICAicHJvZmlsZUlkIiA6ICIwZDdhMjMyN2Y0ZDI0NTlkOTcyNWRmYTQyYzc0YjM4ZSIsCiAgInByb2ZpbGVOYW1lIiA6ICI5MTEiLAogICJzaWduYXR1cmVSZXF1aXJlZCIgOiB0cnVlLAogICJ0ZXh0dXJlcyIgOiB7CiAgICAiU0tJTiIgOiB7CiAgICAgICJ1cmwiIDogImh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvNzc5NzAzMDEwYjUyMmQzODUyMzZlYmUwMWFhOTlkZjIyMWQxMGZiOGEwOTVlZWRmZDZhNGNiNjk2YThjZDFlMCIsCiAgICAgICJtZXRhZGF0YSIgOiB7CiAgICAgICAgIm1vZGVsIiA6ICJzbGltIgogICAgICB9CiAgICB9CiAgfQp9",
    "signature": "ZtQygpEDyrznNi1Cc62V+6pro6gUuFop0Gph0E1gwAe1lEyDLs2MOe+fPGT31P8TA42hj+kMdaxq9VaoOodUqdL76G+O22hb2HK1nRjGEprgyQDsSFHri1KmsbyOHhZud+hcQiRzSxEDQNfcry8TNaGrMq0mIqbiT6V9D5xQuNJ0ZS/czQqmXlRJkboCG5USKdejeRVG5N99mRNwbPLHSgOM+PbnAW5oOnOAM83HJSij5svYPEyKbDcjlovBk3X7jTE1NkeHF8ksaUYz8rhHZC4XC5+lec+sHZRSyM5NIyjtMc715TSqIKP3bfP//cshj9Viqi6p/wFZmK/1IJBcftGgk4+8DQA59MK8en2mSeDeX7VPJflEBQLUyfpt9KCyZEa5RR8k0SXzJ7v/g3XRKShaCGWqN4+i+TrsaqyEUaKgdtPJsTh6QmIBoamOr4pI+w4bFcI+SJiFHmqcEDVAHWinNg848MVDir85/mhET1Je0QNZb6vS2yCpnUyJ9eT2ioCkGxK4ZQliLi8YrNNtLOQjVpeUNx/1VAG3KF1FfuyNh4gwqmGVXFA6MsQg8+2CSniRyTMuwoIpuICy7B2WiNdKzSWixeBY9LJxUfuqiyEWNiBJVs8TTCktNwVyamEkd7wCJhzE9LuCIi9zkoXpLJdrNVIZSEjTWPtlCpVLPKg=",
    "skinName": "911",
    "conversation": {
      "conversationName": "con1",
      "conversationType": "CLICK"
    },
    "location": {
      "world": "world",
      "x": -9.5,
      "y": 154.0,
      "z": 364.5,
      "yaw": 1.6507084,
      "pitch": 11.100024
    },
    "npcType": "PLAYER",
    "hologramLines": [
      "Steve"
    ],
    "refreshSkinDuration": 0,
    "clickActions": [],
    "npcEquip": {},
    "npcFunctions": {
      "holo": true,
      "look": false
    },
    "customizationMap": {}
  },

Here is an example conversation from file ServersNPC/conversations.json including the actual conversations.

{
    "name": "CON1",
    "texts": [
      {
        "lines": [
          "Hey,"
        ],
        "actions": [],
        "delay": 1
      },
      {
        "lines": [
          "How are you?"
        ],
        "actions": [],
        "delay": 1
      },
      {
        "lines": [
          "This is a Test."
        ],
        "actions": [],
        "delay": 1
      },
      {
        "lines": [
          "Bye."
        ],
        "actions": [],
        "delay": 1
      }
    ],
    "radius": 5,
    "delay": 10
  },

I will provide a Pull Request that fixes those two data points but there might be more data that is currently not getting migrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant