Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number of deciles in evaluator plots #35

Closed
3 tasks done
JanBenisek opened this issue Mar 12, 2021 · 0 comments · Fixed by #56
Closed
3 tasks done

Number of deciles in evaluator plots #35

JanBenisek opened this issue Mar 12, 2021 · 0 comments · Fixed by #56
Assignees
@sborms
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v1.0.2

Comments

@JanBenisek
Copy link
Contributor

JanBenisek commented Mar 12, 2021 •
edited by sborms
Loading

Cumulative lift, cumulative response now always show 10 bins (decile), change it to be optional.

  • plot_cumulative_gains() plot has optional number of bins

  • plot_lift_curve() has optional number of bins

  • plot_cumulative_response_curve() has optional number of bins
@JanBenisek JanBenisek added enhancement New feature or request help wanted Extra attention is needed labels Mar 12, 2021
@JanBenisek JanBenisek added this to the v1.0.2 milestone Mar 12, 2021
@JanBenisek JanBenisek added good first issue Good for newcomers and removed help wanted Extra attention is needed labels Mar 16, 2021
@sborms sborms self-assigned this Mar 23, 2021
@sborms sborms mentioned this issue Mar 23, 2021
Merged
@JanBenisek JanBenisek linked a pull request Mar 24, 2021 that will close this issue
n_bins parameter to Evaluator() to control lift curve computation #56
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sborms sborms

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v1.0.2
Development

Successfully merging a pull request may close this issue.

n_bins parameter to Evaluator() to control lift curve computation PythonPredictions/cobra
2 participants
@JanBenisek @sborms