Make changes to rely on ADL get instead of std::get in AFQMC #5239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test this please |
|
This is the list of errors I see in the CI so far:
I see this one passing for what it is worth:
|
|
Test this please |
|
@correaa AFQMC update seems good. |
|
ok, so it is possible to merge then? I will keep working on the side to make the complex afqmc work with newer versions of Multi. But at least I can keep developing Multi without breaking the real version (and the rest of the code). |
prckent
approved these changes
Nov 22, 2024
|
After this PR and those related to it on Thursday, the nightly tests are clear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Namely restore part of #5228 without update of multi.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
laptop
Checklist