You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Originally posted by Shuyun1247 October 27, 2023
Hello,
I've been using your package, and it's been working great for me. However, I encountered some issues when using the MRAF method in your code, specifically when setting the signal region be a rectangular "null_region". I've identified some areas in algorithm.py that, upon modification, resolve these issues. Here are the changes I suggest:
Modification in ijcam_to_knmslm function:
In algorithms.py, find the definition of the function ijcam_to_knmslm. Before the affine transformation, add the line b = b.reshape(-1) to ensure the correct shape for b.
Modification related to null_knm and null_region_knm:
Find the following section in algorithms.py and modify it as follows to account for both null_knm and null_region_knm.
I'm not entirely sure if I was using the SpotHologram incorrectly, but after making these corrections, the method worked properly for both "null_vector" and "null_region" for us. I hope these suggestions are helpful. Let me know if you need any more details or if there are any concerns.
Thank you!
The text was updated successfully, but these errors were encountered:
Discussed in #64
Originally posted by Shuyun1247 October 27, 2023
Hello,
I've been using your package, and it's been working great for me. However, I encountered some issues when using the MRAF method in your code, specifically when setting the signal region be a rectangular "null_region". I've identified some areas in
algorithm.py
that, upon modification, resolve these issues. Here are the changes I suggest:Modification in
ijcam_to_knmslm
function:In
algorithms.py
, find the definition of the functionijcam_to_knmslm
. Before the affine transformation, add the lineb = b.reshape(-1)
to ensure the correct shape forb
.Original:
Modified:
Modification related to
null_knm
andnull_region_knm
:Find the following section in
algorithms.py
and modify it as follows to account for bothnull_knm
andnull_region_knm
.Original:
Modified:
...
I'm not entirely sure if I was using the
SpotHologram
incorrectly, but after making these corrections, the method worked properly for both "null_vector" and "null_region" for us. I hope these suggestions are helpful. Let me know if you need any more details or if there are any concerns.Thank you!
The text was updated successfully, but these errors were encountered: