FS: Remove last traces of iscompressed in vfs_zip. #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the uses had already been removed, but remained in the case of a seek. As cmodel now uses seeks during checksum, this uncovered the last use case. As iscompressed wasn't set, the vfsz->defer remained NULL, and thus reading of pk3 content after a seek failed. The origin of this file is FTE, ideally a newer version is imported but the rest of the FTE VFS guts has evolved since last import. fixes QW-Group#885
|
Does not fix the issue on unfortunately. Not sure what I was thinking. It no longer exhibits the issue with msvc, but broken with mingw and clang on Windows at least. |
|
fixed it all for me at least, no more breaks or warnings. |
|
same for me, fixed all the warnings on e1m2 map load |
hemostx
pushed a commit
to hemostx/ezquake-source
that referenced
this pull request
Jan 3, 2025
Most of the uses had already been removed, but remained in the case of a seek. As cmodel now uses seeks during checksum, this uncovered the last use case. As iscompressed wasn't set, the vfsz->defer remained NULL, and thus reading of pk3 content after a seek failed. The origin of this file is FTE, ideally a newer version is imported but the rest of the FTE VFS guts has evolved since last import. fixes QW-Group#885
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the uses had already been removed, but remained in the case of a seek. As cmodel now uses seeks during checksum, this uncovered the last use case.
As iscompressed wasn't set, the vfsz->defer remained NULL, and thus reading of pk3 content after a seek failed.
The origin of this file is FTE, ideally a newer version is imported but the rest of the FTE VFS guts has evolved since last import.
fixes #885