Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the allowed rate limit #51

Open
mushis opened this issue Aug 11, 2020 · 3 comments
Open

change the allowed rate limit #51

mushis opened this issue Aug 11, 2020 · 3 comments

Comments

@mushis
Copy link
Contributor

mushis commented Aug 11, 2020

the client's rate command is limited programmatically to 100000 (100kbs).
when #44 is done, this limit can be reached with 2 or 3 duplicated packets.

I suggest changing this limit to 500000.

@tcsabina
Copy link
Collaborator

tcsabina commented Nov 7, 2022

hi mushi,
Current limit is 100000*3 (3 is the max duplicated packets). Do you think that is still not enough?

Is this a theoretical discussion or there are some use cases when the rate is indeed too low?

@mushis
Copy link
Contributor Author

mushis commented Nov 8, 2022

I did some digging

if (rate > 100000 * MAX_DUPLICATE_PACKETS)

rate = 100000 * MAX_DUPLICATE_PACKETS;

this is strange.
why not just have it: if rate > 300000; rate = 300000

anyway. 100000 bps are not much. I guess in severe cases it might not be enough. Bloodfest?
the programatical limit should be higher imo.

@ciscon
Copy link
Collaborator

ciscon commented Nov 8, 2022

it's so you could change it by changing max_duplicate_packets, as of now you're setting the ceiling at 300000, which is far higher than any server has sv_maxrate set to anyway (even mine). i honestly have no problem increasing it further, though i can't say i've seen a game that reaches anywhere near that even with dups turned on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants