-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Approximate Quantum Compiler #6727
Conversation
# Conflicts: # qiskit/transpiler/synthesis/aqc/gradient.py
@kdk All works on my laptop and I get an identity matrix in the end. I don't know what caused this error, unfortunately. I added a test case with this snippet, this case is closer to the actual workflow of the transpiler. |
As @adekusar-drl , I also was unable to reproduce this issue. |
Upgrading to scipy 1.5 resolved this for me. Can you check if this is compatible with scipy 1.4 and update the |
@kdk I can confirm there are issues with scpi 1.4. I have another error, not the same as you had. Despite it is a deprecation, the tests fail. So, I think it is safer to upgrade the requirements. Please take a look and thanks for spotting this issue. Error
testtools.testresult.real._StringException: Traceback (most recent call last):
File ".../qiskit-terra/test/python/transpiler/aqc/test_aqc.py", line 56, in test_aqc
initial_point=np.array(INITIAL_THETAS),
File ".../qiskit-terra/qiskit/transpiler/synthesis/aqc/aqc.py", line 99, in compile_unitary
jac=approximating_objective.gradient,
File ".../qiskit-terra/qiskit/algorithms/optimizers/scipy_optimizer.py", line 136, in minimize
**self._kwargs,
File ".../envs/dev-terra/lib/site-packages/scipy/optimize/_minimize.py", line 610, in minimize
callback=callback, **options)
File ".../envs/dev-terra/lib/site-packages/scipy/optimize/lbfgsb.py", line 339, in _minimize_lbfgsb
task_str = task.tostring()
DeprecationWarning: tostring() is deprecated. Use tobytes() instead. |
Pull Request Test Coverage Report for Build 1494293906
💛 - Coveralls |
Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
@kdk recent changes include:
|
Hi @kdk are there any news on the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates! This LGTM.
Summary
This is an implementation of Approximate Quantum Compiler from the paper "Best Approximate Quantum Compiling Problems", https://arxiv.org/abs/2106.05649. The implementation is a minimal version and does not include all features from the referenced paper.
Details and comments
The implementation includes:
Authors: