Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to QuantumCircuit and DAGCircuit methods involving Expr expressions #10233

Closed
7 tasks done
Tracked by #10239
jakelishman opened this issue Jun 7, 2023 · 2 comments
Closed
7 tasks done
Tracked by #10239
Assignees
Labels
type: epic A theme of work that contain sub-tasks type: feature request New feature or request
Milestone

Comments

@jakelishman
Copy link
Member

jakelishman commented Jun 7, 2023

What should we add?

This forms a lot of the work needed for actual use of the initial classical-expression design document.

Depends on #10223 and #10224.

Contained issues

  1. type: feature request
    jakelishman
  2. type: feature request
    jakelishman
  3. type: feature request
    jakelishman
  4. type: feature request
    jakelishman
  5. jakelishman
  6. type: feature request
    jakelishman
  7. type: feature request
    jakelishman

In addition to the DAGCircuit methods that are explicitly called out above, I substitute_node_with_block and substitute_node both technically need updating with support for Expr values. However, I think in practice that these operations do not make sense in the same way with control flow, and since we need to rework how the DAGCircuit data structure works with control flow anyway, I don't think they will actually need touching.

edit: in having done this, I think it's actually simple enough and meaningful to define the behaviour for substitute_node_with_dag and substitute_node, and likely will be useful for PRs in the vein of #9580.

@jakelishman jakelishman added type: feature request New feature or request type: epic A theme of work that contain sub-tasks labels Jun 7, 2023
@jakelishman jakelishman added this to the 0.25.0 milestone Jun 7, 2023
@jakelishman jakelishman self-assigned this Jun 30, 2023
@jakelishman
Copy link
Member Author

All contained issues now closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: epic A theme of work that contain sub-tasks type: feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant