Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Expr values to DAGCircuit.__eq__ #10359

Closed
Tracked by #10233
jakelishman opened this issue Jun 29, 2023 · 0 comments · Fixed by #10367
Closed
Tracked by #10233

Add support for Expr values to DAGCircuit.__eq__ #10359

jakelishman opened this issue Jun 29, 2023 · 0 comments · Fixed by #10367
Assignees
@jakelishman
Milestone
0.25.0

Comments

@jakelishman
Copy link
Member

jakelishman commented Jun 29, 2023 •
edited
Loading

The semantic equality checkers of DAGCircuit.__eq__ should continue to work with the remapping Clbit instances into indices. This currently won't work, because DAGNode.semantic_eq converts the .condition field into a simple Python list for comparison, but this doesn't translate well to the general Expr tree.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakelishman jakelishman

Labels
None yet
Projects
None yet
Milestone
0.25.0
Development

Successfully merging a pull request may close this issue.

Add support for semantic equality checking of Exprs in DAGCircuit jakelishman/qiskit-terra
1 participant
@jakelishman