Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Peephole Optimization Before Routing #12562

Closed
sbrandhsn opened this issue Jun 13, 2024 · 1 comment · Fixed by #12727
Closed

Apply Peephole Optimization Before Routing #12562

sbrandhsn opened this issue Jun 13, 2024 · 1 comment · Fixed by #12727
Assignees
Labels

Comments

@sbrandhsn
Copy link
Contributor

What should we add?

We should investigate to apply peephole optimization before routing.

@sbrandhsn sbrandhsn self-assigned this Jun 26, 2024
@mtreinish
Copy link
Member

In principle I agree this is a really good idea, and now that 2q unitary synthesis is quite fast we can get a lot of potential benefit out of this. However, we have tried this in the past for 1q in #11354 but had to revert it in #11360 because it caused issues for people targeting discrete basis sets. The trick for this will be around making sure we don't break that use case in adding this. We'll probably want some conditions in the pass manager construction to avoid doing this in certain conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants