Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reapply "Performance improvement for Collect2qBlocks" (#6534) #6694

Closed
mtreinish opened this issue Jul 7, 2021 · 0 comments · Fixed by #6783
Closed

Reapply "Performance improvement for Collect2qBlocks" (#6534) #6694

mtreinish opened this issue Jul 7, 2021 · 0 comments · Fixed by #6783
Labels
type: enhancement It's working, but needs polishing
Milestone
0.19

Comments

@mtreinish
Copy link
Member

What is the expected enhancement?

Right before the 0.18.0 release we reverted #6534 as it was causing a nondeterministic CI failure for one test (see #6686 for more details). After the 0.18.0 release goes out and #6685 merges we should push a revert of the revert PR and reapply #6534 and get to the bottom of the failures since the performance improvement was good (and it also enables follow-on improvements leveraging retworkx in #6680).
@mtreinish mtreinish added the type: enhancement It's working, but needs polishing label Jul 7, 2021
@mtreinish mtreinish added this to the 0.19 milestone Jul 7, 2021
@kdk kdk changed the title Reapply #6534 Reapply "Performance improvement for Collect2qBlocks" (#6534) Jul 13, 2021
@kdk kdk mentioned this issue Jul 21, 2021
Merged
@mergify mergify bot closed this as completed in #6783 Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement It's working, but needs polishing
Projects
None yet
Milestone
0.19
Development

Successfully merging a pull request may close this issue.

Reapply "Performance improvement for Collect2qBlocks (#6534)" kdk/qiskit-terra
1 participant
@mtreinish