-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strip _v2
from name in fake BackendV2
classes
#9453
Comments
I would like to work on this issue |
This seems reasonable to me. @mtreinish Can you say if the |
Thanks for the context @HuangJunye , that sounds good to me! |
hi sorry for the late response, I had exams going on |
@shivalee12 the |
Environment
What is happening?
Fake
BackendV2
classes have_v2
appended to the end of their names despite the fact that they use the same device specification as theirBackendV1
counterparts.This is inconsistent with the naming convention used for real backends, where the name is independent of the backend version that exposes it; making such name exclusively tight to the underlying device and therefore a good device identifier.
How can we reproduce the issue?
Outputs:
What should happen?
Name attr in fake backends should depend only on the fake device that gets exposed, and not on the
Backend
version that exposes it (i.e. consistent with the behavior for real backends).Any suggestions?
Strip
_v2
from name in fakeBackendV2
classes.The text was updated successfully, but these errors were encountered: