Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations from mpl circuit drawer #10020

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

enavarro51
Copy link
Contributor

Details and comments

This PR removes the qregs, cregs, layout, and global phase arguments to the MatplotlibDrawer class. These are now being inferred from the circuit passed to the drawer.

@enavarro51 enavarro51 requested review from a team and nonhermitian as code owners April 22, 2023 17:18
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Apr 22, 2023
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4773898240

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 20 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.06%) to 85.919%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.76%
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 1 95.37%
crates/accelerate/src/sabre_swap/mod.rs 2 99.53%
crates/qasm2/src/lex.rs 4 90.89%
crates/qasm2/src/parse.rs 12 97.11%
Totals Coverage Status
Change from base Build 4766039524: 0.06%
Covered Lines: 70988
Relevant Lines: 82622

💛 - Coveralls

Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ace, thanks Edwin.

@jakelishman jakelishman added this to the 0.25.0 milestone Apr 27, 2023
@jakelishman jakelishman added Changelog: Removal Include in the Removed section of the changelog mod: visualization qiskit.visualization labels Apr 27, 2023
@jakelishman jakelishman added this pull request to the merge queue Apr 27, 2023
Merged via the queue into Qiskit:main with commit 21caf38 Apr 27, 2023
king-p3nguin pushed a commit to king-p3nguin/qiskit-terra that referenced this pull request May 22, 2023
* Remove deprecated args from mpl drawer

* Reno mod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo mod: visualization qiskit.visualization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants