Fix deprecation warnings emitted by import qiskit.primitives
#10287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primitives still need to support the legacy `qiskit.opflow.PauliSumOp` while that object is deprecated but not removed. However, we do not want the import of `qiskit.primitives` to need to import `opflow` to do that, since that will cause the deprecation warnings emitted by the import of `opflow` to be hidden (they'll be blamed on Qiskit library code, so hidden by default). All type-hint usage we can hide behind the `TYPE_CHECKING` static analysis gate. For cases where we were actively runtime type-checking an object, we can gate the `isinstance` check behind a check that `qiskit.opflow` is already imported; the object cannot be a `PauliSumOp` if the module isn't initialised.
jakelishman
added
stable backport potential
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 5278300292
💛 - Coveralls |
ikkoham
approved these changes
Jun 15, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jun 15, 2023
The primitives still need to support the legacy `qiskit.opflow.PauliSumOp` while that object is deprecated but not removed. However, we do not want the import of `qiskit.primitives` to need to import `opflow` to do that, since that will cause the deprecation warnings emitted by the import of `opflow` to be hidden (they'll be blamed on Qiskit library code, so hidden by default). All type-hint usage we can hide behind the `TYPE_CHECKING` static analysis gate. For cases where we were actively runtime type-checking an object, we can gate the `isinstance` check behind a check that `qiskit.opflow` is already imported; the object cannot be a `PauliSumOp` if the module isn't initialised. (cherry picked from commit 81964e6)
jakelishman
added a commit
that referenced
this pull request
Jun 15, 2023
… (#10290) The primitives still need to support the legacy `qiskit.opflow.PauliSumOp` while that object is deprecated but not removed. However, we do not want the import of `qiskit.primitives` to need to import `opflow` to do that, since that will cause the deprecation warnings emitted by the import of `opflow` to be hidden (they'll be blamed on Qiskit library code, so hidden by default). All type-hint usage we can hide behind the `TYPE_CHECKING` static analysis gate. For cases where we were actively runtime type-checking an object, we can gate the `isinstance` check behind a check that `qiskit.opflow` is already imported; the object cannot be a `PauliSumOp` if the module isn't initialised. (cherry picked from commit 81964e6) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The primitives still need to support the legacy
qiskit.opflow.PauliSumOpwhile that object is deprecated but not removed. However, we do not want the import ofqiskit.primitivesto need to importopflowto do that, since that will cause the deprecation warnings emitted by the import ofopflowto be hidden (they'll be blamed on Qiskit library code, so hidden by default).All type-hint usage we can hide behind the
TYPE_CHECKINGstatic analysis gate. For cases where we were actively runtime type-checking an object, we can gate theisinstancecheck behind a check thatqiskit.opflowis already imported; the object cannot be aPauliSumOpif the module isn't initialised.Details and comments
Fix #10245