Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAGCircuit: Add get_causal_cone method #10325
DAGCircuit: Add get_causal_cone method #10325
Changes from 13 commits
1960f34
7f633e7
9f98755
5df78a4
e7357ed
b599f84
7afeaca
23d4bf4
9b67119
be9df27
6d57296
e201796
7959ffc
2bcced6
373673c
7cdb264
4e80937
59fb330
16350c5
9158c03
d10eb8e
d129ffc
b924ea2
d66e2f0
65109c3
005f077
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be quantum predecessors too, but if the input is a
Qubit
then there is no way thatoutput_node
could have a classical wire into it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want to add a check on:
not getattr(node_to_check.op, "_directive")
which is an expansion of the barrier check so it'll exclude other directives too, like snapshot from aer, etc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to hold to the statement of ignoring the classical wires should we change this to?:
(and above as well).