Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily pin scipy<1.11 in CI #10348

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

jakelishman
Copy link
Member

Summary

The newest Scipy on Windows seems to have caused a convergence error in some of the Weyl-chamber code. This pins Scipy temporarily while we resolve that issue.

Details and comments

See #10345 for more detail.

The newest Scipy on Windows seems to have caused a convergence error in
some of the Weyl-chamber code.  This pins Scipy temporarily while we
resolve that issue.
@jakelishman jakelishman added type: qa Issues and PRs that relate to testing and code quality stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels Jun 26, 2023
@jakelishman jakelishman requested a review from a team as a code owner June 26, 2023 14:56
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5379706758

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 85.959%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.76%
crates/qasm2/src/lex.rs 4 91.39%
crates/qasm2/src/parse.rs 6 97.58%
Totals Coverage Status
Change from base Build 5379254657: -0.03%
Covered Lines: 71435
Relevant Lines: 83104

💛 - Coveralls

@jakelishman jakelishman added this pull request to the merge queue Jun 26, 2023
Merged via the queue into Qiskit:main with commit 791a454 Jun 26, 2023
mergify bot pushed a commit that referenced this pull request Jun 26, 2023
The newest Scipy on Windows seems to have caused a convergence error in
some of the Weyl-chamber code.  This pins Scipy temporarily while we
resolve that issue.

(cherry picked from commit 791a454)
github-merge-queue bot pushed a commit that referenced this pull request Jun 26, 2023
The newest Scipy on Windows seems to have caused a convergence error in
some of the Weyl-chamber code.  This pins Scipy temporarily while we
resolve that issue.

(cherry picked from commit 791a454)

Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
jlapeyre pushed a commit to ewinston/qiskit that referenced this pull request Jun 28, 2023
The newest Scipy on Windows seems to have caused a convergence error in
some of the Weyl-chamber code.  This pins Scipy temporarily while we
resolve that issue.
@jakelishman jakelishman deleted the pin-scipy-1.11 branch July 19, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants