Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inner qubit mapping in UnitarySynthesis #10405

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Fix inner qubit mapping in UnitarySynthesis #10405

merged 1 commit into from
Jul 13, 2023

Conversation

kevinhartman
Copy link
Contributor

Summary

Fixes an issue with the UnitarySynthesis pass where circuits with control flow were not properly mapped to the provided target.

Details and comments

Issue found while enabling control flow support in optimization level 3.

https://dev.azure.com/qiskit-ci/qiskit-terra/_build/results?buildId=47531&view=logs&j=80763036-ed5e-5d3e-143d-8ae8edc29f03&t=0b590cc4-1220-55fc-f610-714bdf68abc8&l=24136

@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@kevinhartman kevinhartman added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Jul 7, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5482438552

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.005%) to 85.987%
Files with Coverage Reduction New Missed Lines %
qiskit/circuit/tools/pi_check.py 1 91.23%
qiskit/pulse/library/waveform.py 3 93.75%
crates/qasm2/src/lex.rs 5 90.89%
Totals Coverage Status
Change from base Build 5482277685: 0.005%
Covered Lines: 71632
Relevant Lines: 83306
💛 - Coveralls

@kevinhartman kevinhartman mentioned this pull request Jul 7, 2023
Closed
@mtreinish mtreinish added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Jul 7, 2023
@kevinhartman kevinhartman added this to the 0.25.0 milestone Jul 13, 2023
@mtreinish mtreinish modified the milestones: 0.25.0, 0.24.2 Jul 13, 2023
mtreinish
mtreinish approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, the bit mapping was clearly an oversight before and the fix is straightforward and consistent with how it's done in other passes.

@mtreinish mtreinish added this pull request to the merge queue Jul 13, 2023
Merged via the queue into Qiskit:main with commit 100a997 Jul 13, 2023
mergify bot pushed a commit that referenced this pull request Jul 13, 2023
@kevinhartman @mergify
Fix inner qubit mapping in UnitarySynthesis pass. (#10405)
1d3def3 
(cherry picked from commit 100a997)
@mergify mergify bot mentioned this pull request Jul 13, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 14, 2023
@mergify @kevinhartman
Fix inner qubit mapping in UnitarySynthesis pass. (#10405) (#10431)
2317c83 
(cherry picked from commit 100a997)

Co-authored-by: Kevin Hartman <kevin@hart.mn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

@alexanderivrii alexanderivrii Awaiting requested review from alexanderivrii alexanderivrii is a code owner

@ShellyGarion ShellyGarion Awaiting requested review from ShellyGarion ShellyGarion is a code owner

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
0.24.2
Development

Successfully merging this pull request may close these issues.
4 participants
@kevinhartman @qiskit-bot @coveralls @mtreinish