Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject bad values in SparsePauliOp.paulis setter (backport #10437) #10643

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 16, 2023

This is an automatic backport of pull request #10437 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Fix Sparse pauli setter to update dimension info

* Fix Sparse pauli setter to verify dimension info

Value error will be raised if:
1. Number of qubits are not equal
2. Number of elements in PauliList are not equal

* Add tests

* Add release note

---------

Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Co-authored-by: Ikko Hamamura <ikkoham@users.noreply.github.com>
(cherry picked from commit fe87015)
@mergify mergify bot requested review from ikkoham and a team as code owners August 16, 2023 08:36
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @ikkoham

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5876548193

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 18 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.01%) to 87.252%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.76%
qiskit/extensions/unitary.py 1 93.75%
qiskit/quantum_info/operators/symplectic/sparse_pauli_op.py 1 93.28%
qiskit/extensions/quantum_initializer/squ.py 2 80.0%
crates/qasm2/src/parse.rs 6 97.6%
crates/qasm2/src/lex.rs 7 90.63%
Totals Coverage Status
Change from base Build 5872516943: -0.01%
Covered Lines: 74096
Relevant Lines: 84922

💛 - Coveralls

@1ucian0 1ucian0 added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Aug 16, 2023
@ikkoham ikkoham added this pull request to the merge queue Aug 16, 2023
Merged via the queue into stable/0.25 with commit 48a7b82 Aug 16, 2023
14 checks passed
@mergify mergify bot deleted the mergify/bp/stable/0.25/pr-10437 branch August 16, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants