-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #9355 deprecate visualize_transition #12287
fixes #9355 deprecate visualize_transition #12287
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
|
releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml
Outdated
Show resolved
Hide resolved
…aa58.yaml Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com>
…aa58.yaml Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied changes as suggested
releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM thanks a ton for doing this. I left a few inline suggestions that I just applied mainly normalizing the deprecation message to be consistent with other deprecations and updated the release note language.
Pull Request Test Coverage Report for Build 10110162437Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* added deprecation warnings and decorators to transition_visualization.py * fixed style with tox -epy310 -eblack * added release notes * added to warning category=DeprecationWarning and stacklevel=2 * Update releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com> * Update releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com> * Apply suggestions from code review * Fix lint complaint --------- Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com> (cherry picked from commit 4ec51d1)
* added deprecation warnings and decorators to transition_visualization.py * fixed style with tox -epy310 -eblack * added release notes * added to warning category=DeprecationWarning and stacklevel=2 * Update releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com> * Update releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com> * Apply suggestions from code review * Fix lint complaint --------- Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com> (cherry picked from commit 4ec51d1) Co-authored-by: YingHongTham <thamyinghong@gmail.com>
* added deprecation warnings and decorators to transition_visualization.py * fixed style with tox -epy310 -eblack * added release notes * added to warning category=DeprecationWarning and stacklevel=2 * Update releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com> * Update releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com> * Apply suggestions from code review * Fix lint complaint --------- Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Fixes #9355
Summary
Addresses #9355 #9355, request to deprecate visualize_transition;
visualize_transition is the sole export of the module qiskit.visualization.transition_visualization,
so the entire module is deprecated as well.
Details and comments
Tentative plan to migrate visualize_transition to somewhere in https://qiskit.org/ecosystem/, probably QuSTaR/kaleidoscope
No tests existed before, no tests added.