-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clifford gates to collect_cliffords (backport #12750) #12763
Conversation
* add clifford gates to collect_cliffords * replace hard coded clifford names by clifford_circuit names * move import * replace hard coded clifford names in random_clifford_circuit * add release notes * add permutation to collect_clifford gate list (cherry picked from commit 41267ec) # Conflicts: # qiskit/circuit/random/utils.py
Cherry-pick of 41267ec has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 9894614827Details
💛 - Coveralls |
Summary
This PR adds some Clifford gates to the
CollectClifford()
transpiler pass.Details and comments
This is an immediate bugfix which does not handle the following problems:
When adding a gate to the Clifford class, it should be added in other places of the code,
and there is no single list of gates that the Clifford class supports.
qiskit/qiskit/transpiler/passes/optimization/collect_cliffords.py
Line 27 in 6b57b78
and
qiskit/qiskit/circuit/random/utils.py
Line 290 in fa3d6df
The current Clifford class can handle certain
u
gates (for certain angles), and this does not appear in the docs, neither in the code above:qiskit/qiskit/quantum_info/operators/symplectic/clifford_circuits.py
Line 100 in fa3d6df
This is an automatic backport of pull request #12750 done by [Mergify](https://mergify.com).