Fix dag visualization with Var wires #12848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the dag visualization for DAGs with classical variables. The Var type was not handled in the attribute callback functions for nodes and edges. This was causing the visualizer to fail if the dag contained these types. This fixes this by adding explict handling for the Var types and using the name attribute of the Var object.
mtreinish
added
Changelog: Bugfix
|
One or more of the following people are relevant to this code:
|
mtreinish
added
the
stable backport potential
jakelishman
reviewed
Jul 29, 2024
Pull Request Test Coverage Report for Build 10291911483Details
💛 - Coveralls |
|
I'm skeptical of a test here, mostly because it's a visualization test and the only thing I can do besides asserting it doesn't fail is compare the output visualization. I'm not a big fan of image diff tests, and in this case will be very tricky for me to write because I have a newer version of graphviz installed locally and none of the existing graphviz based visualization tests pass locally. |
|
For visualisation, I'm basically fine just asserting that it doesn't fail for the reasons you give. It would be good to make sure that the path is at least run in the tests. |
|
@Mergifyio backport stable/1.1 stable/1.2 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
* Fix dag visualization with Var wires This commit fixes the dag visualization for DAGs with classical variables. The Var type was not handled in the attribute callback functions for nodes and edges. This was causing the visualizer to fail if the dag contained these types. This fixes this by adding explict handling for the Var types and using the name attribute of the Var object. * Add release note and test (cherry picked from commit adbe887)
mergify bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
* Fix dag visualization with Var wires This commit fixes the dag visualization for DAGs with classical variables. The Var type was not handled in the attribute callback functions for nodes and edges. This was causing the visualizer to fail if the dag contained these types. This fixes this by adding explict handling for the Var types and using the name attribute of the Var object. * Add release note and test (cherry picked from commit adbe887)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
* Fix dag visualization with Var wires This commit fixes the dag visualization for DAGs with classical variables. The Var type was not handled in the attribute callback functions for nodes and edges. This was causing the visualizer to fail if the dag contained these types. This fixes this by adding explict handling for the Var types and using the name attribute of the Var object. * Add release note and test (cherry picked from commit adbe887) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
* Fix dag visualization with Var wires This commit fixes the dag visualization for DAGs with classical variables. The Var type was not handled in the attribute callback functions for nodes and edges. This was causing the visualizer to fail if the dag contained these types. This fixes this by adding explict handling for the Var types and using the name attribute of the Var object. * Add release note and test (cherry picked from commit adbe887) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit fixes the dag visualization for DAGs with classical variables. The Var type was not handled in the attribute callback functions for nodes and edges. This was causing the visualizer to fail if the dag contained these types. This fixes this by adding explicit handling for the Var types and using the name attribute of the Var object.
Details and comments