-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 1.1.2 #12927
Prepare 1.1.2 #12927
Conversation
One or more of the following people are relevant to this code:
|
releasenotes/notes/fix-bitarray-slice-bits-shots-c9cb7e5d907722f5.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the one release note I flagged in my previous comment I think this LGTM. Once the proposed revert in #12929 merges I think we can merge this and go ahead and tag the release.
22605c6
to
60d78ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for doing this.
Summary
Prepares the release of minor version 1.1.2.
Details and comments
There's a fix in here for version parsing of
matplotlib
(their current version ismatplotlib 3.9.1.post1
which we fail to parse) which we also need onmain
(parsing logic is borrowed from our qpy module). I will open a separate PR on that for main, and we can choose to either backport it to this branch or just keep this PR as is.