Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix StatePreparation's normalize argument #12988

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Fix StatePreparation's normalize argument #12988

merged 1 commit into from
Aug 19, 2024

Conversation

Cryoris
Copy link
Contributor

@Cryoris Cryoris commented Aug 19, 2024

Summary

Fixes #12984. The definition didn't use the normalized parameters, if the input is synthesized by isometry.

@Cryoris Cryoris added stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: Bugfix Include in the "Fixed" section of the changelog labels Aug 19, 2024
@Cryoris Cryoris requested a review from a team as a code owner August 19, 2024 14:51
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia

@Cryoris Cryoris mentioned this pull request Aug 19, 2024
Closed
ElePT
ElePT approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElePT ElePT added this to the 1.2.1 milestone Aug 19, 2024
@ElePT ElePT enabled auto-merge August 19, 2024 15:41
@ElePT ElePT added this pull request to the merge queue Aug 19, 2024
Merged via the queue into Qiskit:main with commit 5963027 Aug 19, 2024
15 checks passed
mergify bot pushed a commit that referenced this pull request Aug 19, 2024
@Cryoris @mergify
fix stateprep's normalize (#12988)
6f8f8c2 
(cherry picked from commit 5963027)
@mergify mergify bot mentioned this pull request Aug 19, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 20, 2024
@mergify @Cryoris @ElePT
fix stateprep's normalize (#12988) (#12992)
5a246db 
(cherry picked from commit 5963027)

Co-authored-by: Julien Gacon <jules.gacon@gmail.com>
Co-authored-by: Elena Peña Tapia <epenatap@gmail.com>
@Cryoris Cryoris deleted the fix-stateprep-normalize branch August 20, 2024 12:02
@raynelfss raynelfss mentioned this pull request Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElePT ElePT ElePT approved these changes

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.

Passmanager fails to transpile a basic StatePreparation gate
3 participants
@Cryoris @qiskit-bot @ElePT