Remove legacy-editable option from setuptools builds #13059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We needed this back when `setuptools` first introduced the new editable installations, but at this point it should work more correctly without it; our non-CI configurations haven't included it for some time.
jakelishman
added
type: qa
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 10633042117Details
💛 - Coveralls |
mtreinish
approved these changes
Aug 30, 2024
mergify bot
pushed a commit
that referenced
this pull request
Aug 30, 2024
We needed this back when `setuptools` first introduced the new editable installations, but at this point it should work more correctly without it; our non-CI configurations haven't included it for some time. (cherry picked from commit 05a9b55)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 30, 2024
We needed this back when `setuptools` first introduced the new editable installations, but at this point it should work more correctly without it; our non-CI configurations haven't included it for some time. (cherry picked from commit 05a9b55) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We needed this back when
setuptoolsfirst introduced the new editable installations, but at this point it should work more correctly without it; our non-CI configurations haven't included it for some time.Details and comments
Let's just let CI run to ensure there's no further complications from this removal.