Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy-editable option from setuptools builds (backport #13059) #13060

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 30, 2024

Summary

We needed this back when setuptools first introduced the new editable installations, but at this point it should work more correctly without it; our non-CI configurations haven't included it for some time.

Details and comments

Let's just let CI run to ensure there's no further complications from this removal.


This is an automatic backport of pull request #13059 done by [Mergify](https://mergify.com).

We needed this back when `setuptools` first introduced the new editable
installations, but at this point it should work more correctly without
it; our non-CI configurations haven't included it for some time.

(cherry picked from commit 05a9b55)
@mergify mergify bot requested a review from a team as a code owner August 30, 2024 15:12
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Aug 30, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10635038469

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 89.85%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 2 93.23%
Totals Coverage Status
Change from base Build 10577165228: 0.02%
Covered Lines: 66922
Relevant Lines: 74482

💛 - Coveralls

@jakelishman jakelishman added this pull request to the merge queue Aug 30, 2024
Merged via the queue into stable/1.2 with commit 8346066 Aug 30, 2024
18 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.2/pr-13059 branch August 30, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants