Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port RemoveDiagonalGatesBeforeMeasure to rust #13065
Port RemoveDiagonalGatesBeforeMeasure to rust #13065
Changes from 10 commits
e470693
285b54b
4a72590
9b99639
536667b
b6dc53d
08f5d13
f543a66
053a7f1
41047b5
4e57891
3b5034f
d5a7895
98fb0b4
0a4968b
68c24e4
f427c4d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that there are some 1-qubit and 2-qubit diagonal gates that did not appear in the original list, so I added them here (I'll add them to the tests later).
There is also a 3-qubit diagonal gate:
CCZGate
(which was not added in this PR)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, there is also an n-qubit diagonal gate:
MCPhaseGate
. This gate was not handled this PR.This is since the algorithm given here that goes over all the successors of each of the predecessors would be
O(n^2)
and notO(n)
.