Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the text drawer with partially idle wires #13149

Merged
merged 5 commits into from
Sep 17, 2024
Merged

Fix the text drawer with partially idle wires #13149

merged 5 commits into from
Sep 17, 2024

Conversation

Cryoris
Copy link
Contributor

@Cryoris Cryoris commented Sep 13, 2024

Summary

Fixes #13128.

Details and comments

We think the issue is that the layers method adds the node by reference instead of a copy, which causes the _LayerSpooler to mutate the DAG while building the visualization layers.

@Cryoris @mrossinek
Fix the text drawer with partially idle wires
1ec1ef0 
Co-authored-by: Max Rossmannek <oss@zurich.ibm.com>
@Cryoris Cryoris added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Sep 13, 2024
@Cryoris Cryoris added this to the 1.2.2 milestone Sep 13, 2024
@Cryoris Cryoris requested review from nonhermitian and a team as code owners September 13, 2024 12:06
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

@Cryoris @ElePT
Update test/python/visualization/test_circuit_text_drawer.py
863778b 
Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
@1ucian0 1ucian0 linked an issue Sep 16, 2024 that may be closed by this pull request
qc.draw('text', idle_wires=False) results in ValueError : min() arg is an empty sequence #13128
Closed
jakelishman
jakelishman reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change - I also checked that this does fix the MPL drawer bug as well, so it'd be good to include that in the release note, then we can merge this.

releasenotes/notes/fix-textdrawer-idle-layer-91e6c3c6d7656e98.yaml Outdated Show resolved Hide resolved
@mrossinek @jakelishman
Update releasenotes/notes/fix-textdrawer-idle-layer-91e6c3c6d7656e98.…
c6b5117 
…yaml

Co-authored-by: Jake Lishman <jake@binhbar.com>
@jakelishman jakelishman mentioned this pull request Sep 17, 2024
Closed
@jakelishman jakelishman added this pull request to the merge queue Sep 17, 2024
Merged via the queue into Qiskit:stable/1.2 with commit fd7560b Sep 17, 2024
14 checks passed
@mrossinek mrossinek deleted the fix-partial-idle-wires branch September 18, 2024 06:36
@raynelfss raynelfss mentioned this pull request Oct 28, 2024
Merged
@t-imamichi t-imamichi mentioned this pull request Nov 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElePT ElePT ElePT left review comments

@mrossinek mrossinek mrossinek left review comments

@jakelishman jakelishman jakelishman approved these changes

@nonhermitian nonhermitian Awaiting requested review from nonhermitian nonhermitian is a code owner

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Milestone
1.2.2
Development

Successfully merging this pull request may close these issues.

qc.draw('text', idle_wires=False) results in ValueError : min() arg is an empty sequence
6 participants
@Cryoris @qiskit-bot @jakelishman @mrossinek @ElePT @1ucian0