-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more default trials to sabre layout #13360
Merged
Merged
Commits on Oct 23, 2024
-
Add more default trials to sabre layout
Right now sabre layout uses n random trials (as specified by the user or defaulting to num_cpus) and since Qiskit#12453 one additional trial taking the qubits of the densest subgraph as a starting point. There are also a couple of other trivial examples to try which may or may not produce better results depending on the circuit, a trivial layout and a reverse trivial layout. In the case of a hardware efficient circuit the trivial layout will map exactly and would always be picked. When running in a preset pass manager sabre should never be called in this scenario because VF2Layout will find the mapping, but the incremental cost of adding the trial is minimal. Similarly the cost of a reversed trivial layout (where virtual qubit 0 -> n, 1 -> n - 1, etc.) is trivial and may in some scenarios produce a better results.
Configuration menu - View commit details
-
Copy full SHA for a153cd1 - Browse repository at this point
Copy the full SHA a153cd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a2a130 - Browse repository at this point
Copy the full SHA 2a2a130View commit details
Commits on Oct 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 735856b - Browse repository at this point
Copy the full SHA 735856bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69d9b16 - Browse repository at this point
Copy the full SHA 69d9b16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47d9689 - Browse repository at this point
Copy the full SHA 47d9689View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28a8fe1 - Browse repository at this point
Copy the full SHA 28a8fe1View commit details
Commits on Oct 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e51ecb9 - Browse repository at this point
Copy the full SHA e51ecb9View commit details -
Apply suggestions from code review
Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 41121f2 - Browse repository at this point
Copy the full SHA 41121f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b24047f - Browse repository at this point
Copy the full SHA b24047fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.