Fix twirling asv benchmark #13421
Merged
Fix twirling asv benchmark #13421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Qiskit#13331 merged the nightly asv runs have been failing. This is because the asv twirling benchmark code was updated in that PR to use the new twirling function instead of the embedded equivalent. However, in the PR the name of that function was renamed from twirl_circuit to pauli_twirl_2q_gates during the development of the feature. This rename was missed in the asv benchmark, and as nothing executes the asv code in CI this went uncaught until the asv nightly runs. This commit fixes this oversight and updates the function name to the correct name so that the asv benchmarks no longer fail on import.
mtreinish
added
type: qa
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 11779961022Details
💛 - Coveralls |
mtreinish
commented
Nov 11, 2024
kevinhartman
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since #13331 merged the nightly asv runs have been failing. This is because the asv twirling benchmark code was updated in that PR to use the new twirling function instead of the embedded equivalent. However, in the PR the name of that function was renamed from twirl_circuit to pauli_twirl_2q_gates during the development of the feature. This rename was missed in the asv benchmark, and as nothing executes the asv code in CI this went uncaught until the asv nightly runs. This commit fixes this oversight and updates the function name to the correct name so that the asv benchmarks no longer fail on import.
Details and comments