add abs method to ParameterExpression #9309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiskit-bot
added
the
Community PR
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Cryoris
reviewed
Dec 21, 2022
There was a problem hiding this comment.
Overall LGTM, but since @jakelishman reviewed the first version of the PR it would be good if he could have another look 🙂
Pull Request Test Coverage Report for Build 5001210513
💛 - Coveralls |
Cryoris
reviewed
May 3, 2023
Cryoris
reviewed
May 15, 2023
releasenotes/notes/add-abs-to-parameterexpression-347ffef62946b38b.yaml
Outdated
Show resolved
Hide resolved
…b38b.yaml Co-authored-by: Julien Gacon <gaconju@gmail.com>
Cryoris
approved these changes
May 17, 2023
Cryoris
added
the
Changelog: New Feature
king-p3nguin
added a commit
to king-p3nguin/qiskit-terra
that referenced
this pull request
May 22, 2023
* added abs method to parameterexpression * fixed wrong call in abs function * changed definition of abs to __abs__ * additionally implemented __le__, __ge__, __lt__, __gt__ operators * fixed requested features and implemented more tests for __lt__, __gt__ * fixed lint errors in parameterexpression and its tests * fixed formatting error in docstrings * removed __lt__ and friends, fixed recommendations * added more tests for abs function * fixed lint * added a releasenote to document change * mod function & add more tests * add new line at the end of file * fix lint * add alias of __abs__ for doc * mod test_compile_with_ufunc * add test * fix test * fix test * fix test * fix test * fix test * Update test_parameters.py * Update releasenotes/notes/add-abs-to-parameterexpression-347ffef62946b38b.yaml Co-authored-by: Julien Gacon <gaconju@gmail.com> --------- Co-authored-by: Christopher Zachow <christopher.zachow@sva.de> Co-authored-by: Julien Gacon <gaconju@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Co-authored-by: @czachow Christopher.zachow@sva.de
__abs__()method to the class ParameterExpressionabs()method to the class ParameterExpression__abs__()will not be documentedDetails and comments