-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding HLS plugins for linear functions and cliffords #9399
Changes from 3 commits
b8326d3
d5dabc3
d0aef38
4e4e17d
a91f5d2
0dbcf31
92356f2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
--- | ||
features: | ||
- | | ||
Added high-level-synthesis plugins for :class:`.LinearFunction` and for | ||
:class:`qiskit.quantum_info.Clifford`, extending the set of synthesis | ||
methods that can be called from :class:`~qiskit.transpiler.passes.HighLevelSynthesis` | ||
transpiler pass. | ||
For :class:`.LinearFunction` the newly available plugins are | ||
:class:`.PMHSynthesisLinearFunction` and :class:`.KMSSynthesisLinearFunction`. | ||
For :class:`qiskit.quantum_info.Clifford` the newly available plugins are | ||
:class:`.AGSynthesisClifford`, :class:`.BMSynthesisClifford`, | ||
:class:`.GreedySynthesisClifford` and :class:`.LayerSynthesisClifford`. | ||
Please refer to :mod:`qiskit.synthesis` documentation for more information | ||
about each individual method. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add a table or something that maps the plugin names to the methods? I think that'll be good for users so they know what the plugin names are going to be. Also having an example of how to use it with transpile would go a long way too. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done in 0dbcf31. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be good to say explicitly in the docstring here (and for the other plugin classes) that the name of this plugin is
"ag"
so that users know how to specify the plugin.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in a91f5d2.