Bug fix property and methods of BackendV2Converter #9502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiskit-bot
added
the
Community PR
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
nkanazawa1989
added
stable backport potential
Pull Request Test Coverage Report for Build 4065329297
💛 - Coveralls |
to24toro
force-pushed
the
fix/backend_compat
branch
from
0d58e54
to
1a0f77c
Compare
releasenotes/notes/fix-backendv2converter-de342352cf882494.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/fix-backendv2converter-de342352cf882494.yaml
Outdated
Show resolved
Hide resolved
mtreinish
approved these changes
Feb 1, 2023
|
|
||
| def drive_channel(self, qubit: int): | ||
| self._config.drive(qubit) | ||
| return self._config.drive(qubit) |
There was a problem hiding this comment.
Lol, this is my bad. I switch back and forth between rust and python too much (Rust has an implicit return on the last line of a function without a semicolon)
There was a problem hiding this comment.
Certainly, the reason is very persuasive!
mergify bot
pushed a commit
that referenced
this pull request
Feb 1, 2023
* fix property and methods of BackendV2Converter * add reno * Update releasenotes/notes/fix-backendv2converter-de342352cf882494.yaml * Update releasenotes/notes/fix-backendv2converter-de342352cf882494.yaml --------- Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit df258d4)
mergify bot
added a commit
that referenced
this pull request
Feb 1, 2023
* fix property and methods of BackendV2Converter * add reno * Update releasenotes/notes/fix-backendv2converter-de342352cf882494.yaml * Update releasenotes/notes/fix-backendv2converter-de342352cf882494.yaml --------- Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit df258d4) Co-authored-by: Kento Ueda <38037695+to24toro@users.noreply.github.com>
pranay1990
pushed a commit
to pranay1990/qiskit-terra
that referenced
this pull request
Feb 9, 2023
* fix property and methods of BackendV2Converter * add reno * Update releasenotes/notes/fix-backendv2converter-de342352cf882494.yaml * Update releasenotes/notes/fix-backendv2converter-de342352cf882494.yaml --------- Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I found and fixed bugs of
BackendV2Converter.Details and comments
Important and critical bugs to use BackendV2Converter.