Fix inverse of SdgGate in Solovay Kitaev
#9635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
added
stable backport potential
Cryoris
requested review from
a team,
alexanderivrii and
ShellyGarion
as code owners
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Closed
jakelishman
reviewed
Feb 22, 2023
jakelishman
reviewed
Feb 22, 2023
Pull Request Test Coverage Report for Build 4245392985
💛 - Coveralls |
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
* Fix typo and add regression test * add example and include basic_approx in API doc * use assertTrue * use `assertGreater` * run black with the right version this time --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit e52207f)
mergify bot
added a commit
that referenced
this pull request
Feb 22, 2023
* Fix typo and add regression test * add example and include basic_approx in API doc * use assertTrue * use `assertGreater` * run black with the right version this time --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit e52207f) Co-authored-by: Julien Gacon <gaconju@gmail.com>
Eric-Arellano
pushed a commit
to Eric-Arellano/qiskit-terra
that referenced
this pull request
Feb 23, 2023
* Fix typo and add regression test * add example and include basic_approx in API doc * use assertTrue * use `assertGreater` * run black with the right version this time --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9585 and adds
generate_basic_approximationto the API doc.Details and comments
Due to a typo (
sgdinstead ofsdg) the inverse of theSdgGatewas not correctly identified, see #9585.This also adds the
generate_basic_approximationto the docs as this function must be used for basis gate sets different from the default. The PR also adds an example for this use case to the class docstring.