-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add representation of "switch" #9833
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
This simply adds the representation of a switch statement to Terra, without any of the extra supported needed anywhere else in the package. These will come in follow-up commits.
2735b8d
to
8f9ebe7
Compare
Pull Request Test Coverage Report for Build 4565467629
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall.
I'm digging this interface—very clean!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Let me poke @kdk for review before as well, since most of the control-flow representation stuff is his. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
From offline Slack discussions, and just for posterity (it's me typing):
|
* Add representation of "switch" This simply adds the representation of a switch statement to Terra, without any of the extra supported needed anywhere else in the package. These will come in follow-up commits. * Add missing tests * Fix test naming collision * Clarify comments on representation * Remove comment overlooked in rebase * Fix lint
* Add representation of "switch" This simply adds the representation of a switch statement to Terra, without any of the extra supported needed anywhere else in the package. These will come in follow-up commits. * Add missing tests * Fix test naming collision * Clarify comments on representation * Remove comment overlooked in rebase * Fix lint
Summary
This simply adds the representation of a switch statement to Terra, without any of the extra supported needed anywhere else in the package. These will come in follow-up commits.
Details and comments
It's possible there are references to a builder interface left in this PR in places - I tried to squash all of those when I rebased my original branch (I'll add the builder in a follow-up, and it still needs tests writing). I can either fix them in this PR, or just leave it to make sense when the builder interface is added again.
There's no support added in the rest of the library for this new operation yet; I'll do that in follow-ups.